Skip to content

Fixing EasyCurl AddHeader logic #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonsandlin merged 1 commit into from
Nov 5, 2025
Merged

Fixing EasyCurl AddHeader logic #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions Source/HTTP/Curl/CurlEasyRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,18 +222,32 @@ void CurlEasyRequest::Fail(HRESULT hr)
HRESULT CurlEasyRequest::AddHeader(char const* name, char const* value) noexcept
{
int required = std::snprintf(nullptr, 0, "%s: %s", name, value);
assert(required > 0);
if (required <= 0)
{
return E_FAIL;
}

m_headersBuffer.emplace_back();
auto& header = m_headersBuffer.back();

header.resize(static_cast<size_t>(required), '\0');
int written = std::snprintf(&header[0], header.size() + 1, "%s: %s", name, value);
assert(written == required);
(void)written;
header.resize(static_cast<size_t>(required) + 1);
int written = std::snprintf(&header[0], header.size(), "%s: %s", name, value);
if (written != required)
{
// snprintf failed or truncated; drop this header so we never expose a corrupt entry
m_headersBuffer.pop_back();
return E_FAIL;
}
header.resize(static_cast<size_t>(written));

m_headers = CURL_CALL(curl_slist_append)(m_headers, header.c_str());
curl_slist* appended = CURL_CALL(curl_slist_append)(m_headers, header.c_str());
if (!appended)
{
m_headersBuffer.pop_back();
return E_OUTOFMEMORY;
}

m_headers = appended;
return S_OK;
}

Expand Down