Update task queue to allow operator new overloads to overload all memory allocation#928
Merged
jasonsandlin merged 5 commits intomainfrom Feb 13, 2026
Merged
Update task queue to allow operator new overloads to overload all memory allocation#928jasonsandlin merged 5 commits intomainfrom
jasonsandlin merged 5 commits intomainfrom
Conversation
jasonsandlin
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task queue uses an internal class called LocklessQueue, which is a low level lock-free queue implementation. LocklessQueue creates a block of node objects to hold internal state. Those node objects must be properly aligned in memory for LocklessQueue to work. This was done with aligned mallocs, which bypasses any user-supplied operator new overrides.
This change addresses that by switching LocklessQueue to use standard new / delete via alignas and alignof attributes.
In addition this change contains small payload changes done to the Windows version of TaskQueue:
None of these additional changes is interesting for libHttp, but we need to keep the source code in lockstep with what Windows is using.