Skip to content

Re-enable warning 4244#952

Merged
jplafonta merged 1 commit intomainfrom
user/johlafo/EnableWarning
Apr 1, 2026
Merged

Re-enable warning 4244#952
jplafonta merged 1 commit intomainfrom
user/johlafo/EnableWarning

Conversation

@jplafonta
Copy link
Copy Markdown
Contributor

Warning can't be disabled per security policy. Luckily with vs2022 and latest build tools, disabling is no longer needed.

@jplafonta jplafonta force-pushed the user/johlafo/EnableWarning branch from 6f35182 to 5b3e657 Compare March 31, 2026 19:18
Update zlib submodule from v1.3 to v1.3.2 which includes explicit casts
that resolve C4244 warnings (commit 8a76f02 by levib@microsoft.com).
This allows removing the /wd4244 suppression from the Zlib build items
without breaking builds that use /WX (TreatWarningAsError).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jplafonta jplafonta force-pushed the user/johlafo/EnableWarning branch from 5b3e657 to 219c335 Compare April 1, 2026 13:55
@jplafonta jplafonta merged commit 851d2bd into main Apr 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants