Skip to content

Fix feature not detected errors#1990

Merged
dsrivastavv merged 2 commits intomainfrom
divyan/addvmtoresourcedisk
May 25, 2022
Merged

Fix feature not detected errors#1990
dsrivastavv merged 2 commits intomainfrom
divyan/addvmtoresourcedisk

Conversation

@dsrivastavv
Copy link
Copy Markdown
Contributor

No description provided.

@dsrivastavv dsrivastavv requested a review from squirrelsc as a code owner May 23, 2022 17:17
squirrelsc
squirrelsc previously approved these changes May 23, 2022
@dsrivastavv
Copy link
Copy Markdown
Contributor Author

@squirrelsc I am seeing errors in has_resource_disk feature. Holding merging this PR until that is fixed

@dsrivastavv
Copy link
Copy Markdown
Contributor Author

@squirrelsc Added a fix for intersection issue with AzureDiskOptionSetting and verified against earlier commit

Comment thread lisa/runners/lisa_runner.py Outdated
Comment thread lisa/sut_orchestrator/azure/features.py Outdated
Comment thread lisa/runners/lisa_runner.py Outdated
@dsrivastavv dsrivastavv changed the title Update VM families with no resource disk Fix feature not detected errors May 24, 2022
@dsrivastavv dsrivastavv force-pushed the divyan/addvmtoresourcedisk branch from f5107dc to 661dddf Compare May 24, 2022 22:21
@dsrivastavv dsrivastavv force-pushed the divyan/addvmtoresourcedisk branch from 661dddf to 7950a61 Compare May 24, 2022 22:29
Comment thread lisa/schema.py Outdated
Comment thread lisa/schema.py Outdated
Comment thread lisa/sut_orchestrator/azure/features.py Outdated
Comment thread lisa/sut_orchestrator/azure/features.py Outdated
@dsrivastavv dsrivastavv force-pushed the divyan/addvmtoresourcedisk branch from 7950a61 to 1e5d1d9 Compare May 25, 2022 15:33
@dsrivastavv dsrivastavv merged commit ab80b1b into main May 25, 2022
@dsrivastavv dsrivastavv deleted the divyan/addvmtoresourcedisk branch May 25, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants