Skip to content

Fix gpu extension #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharsonia merged 2 commits into from
May 26, 2022
Merged

Fix gpu extension #2000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2dc9b3
features: gpu: update api-version which fixes gpu installation using …
sharsonia May 25, 2022
d7a9c8a
features: gpu: update supportability for gpu drivers.
sharsonia May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions lisa/sut_orchestrator/azure/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from lisa.features.gpu import ComputeSDK
from lisa.features.resize import ResizeAction
from lisa.node import Node, RemoteNode
from lisa.operating_system import CentOs, Redhat, Suse, Ubuntu
from lisa.operating_system import Redhat, Suse, Ubuntu
from lisa.search_space import RequirementMethod
from lisa.tools import Dmesg, Lspci, Modprobe
from lisa.util import (
Expand Down Expand Up @@ -170,7 +170,7 @@ class Gpu(AzureFeatureMixin, features.Gpu):
{
"publisher": "Microsoft.HpcCompute",
"type": "NvidiaGpuDriverLinux",
"typeHandlerVersion": "1.6",
"typeHandlerVersion": "1.7",
"autoUpgradeMinorVersion": true,
"settings": {
}
Expand All @@ -180,11 +180,16 @@ class Gpu(AzureFeatureMixin, features.Gpu):

def is_supported(self) -> bool:
# TODO: more supportability can be defined here
supported_distro = (CentOs, Redhat, Ubuntu, Suse)
if isinstance(self._node.os, supported_distro):
return True

return False
node = self._node
supported = False
if isinstance(node.os, Redhat):
supported = node.os.information.version >= "7.0.0"
elif isinstance(node.os, Ubuntu):
supported = node.os.information.version >= "18.0.0"
elif isinstance(node.os, Suse):
supported = node.os.information.version >= "15.0.0"

return supported

def get_supported_driver(self) -> List[ComputeSDK]:
driver_list = []
Expand Down