Skip to content

git.get_latest_commit_id() added. #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squirrelsc merged 3 commits into from
Sep 27, 2022
Merged

git.get_latest_commit_id() added. #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9ea804
Added 'get_latest_commit_id' to git tool
Sep 26, 2022
43e15f6
remove 'splitlines()'
Sep 26, 2022
3e4db89
get_latest_commit_id(), fixed the return type
Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lisa/tools/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,17 @@ def list_commit_ids(self, cwd: pathlib.PurePath) -> List[str]:
)
return filter_ansi_escape(result.stdout).splitlines()

def get_latest_commit_id(self, cwd: pathlib.PurePath) -> str:
result = self.run(
"--no-pager log -n 1 --pretty=format:%h",
shell=True,
cwd=cwd,
force_run=True,
expected_exit_code=0,
expected_exit_code_failure_message="Failed to fetch latest commit id.",
)
return filter_ansi_escape(result.stdout)

def init_submodules(self, cwd: pathlib.PurePath) -> None:
self.run(
"submodule update --init",
Expand Down
4 changes: 2 additions & 2 deletions lisa/transformers/kernel_source_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ def get_source_code(self) -> PurePath:
self._log.info(f"checkout code from: '{runbook.ref}'")
git.checkout(ref=runbook.ref, cwd=code_path)

commitids = git.list_commit_ids(cwd=code_path)
self._log.info(f"Kernel HEAD is now at : {commitids[0]}")
latest_commit_id = git.get_latest_commit_id(cwd=code_path)
self._log.info(f"Kernel HEAD is now at : {latest_commit_id}")

return code_path

Expand Down