Skip to content

Conversation

@kamalca
Copy link
Collaborator

@kamalca kamalca commented Dec 11, 2025

Windows and Linux images both use the tag "TrustedLaunchAndConfidentialVmSupported" but their use of the tag is different.

Windows images are generally GP with CVM support. They are intended to be used on GP hardware or CVM hardware. It is a single combined image for both scenarios.

Linux images are generally intended only for CVM. There are separate images for GP scenarios. Testing Linux CVM images on GP hardware is generally not testing an intended use case.

This change treats Windows and Linux VMs separately to recognize this difference in labeling conventions.

Windows and Linux images both use the tag "TrustedLaunchAndConfidentialVmSupported" but their use of the tag is different.

Windows images are generally GP with CVM support. They are intended to be used on GP hardware or CVM hardware. It is a single combined image for both scenarios.

Linux images are generally intended only for CVM. There are separate images for GP scenarios. Testing Linux CVM images on GP hardware is generally not testing an intended use case.

This change treats Windows and Linux VMs separately to recognize this difference in labeling conventions.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces OS-specific handling for the TrustedLaunchAndConfidentialVmSupported security profile tag in Azure images. Windows and Linux images use this tag differently: Windows images are general-purpose with CVM support for both GP and CVM hardware, while Linux images are typically CVM-only with separate images for GP scenarios. The changes ensure that Windows images with this tag support both Standard/SecureBoot and CVM/Stateless security profiles, while Linux images continue to support only CVM/Stateless profiles.

  • Windows images with TrustedLaunchAndConfidentialVmSupported now support Standard, SecureBoot, CVM, and Stateless security profiles
  • Linux images with TrustedLaunchAndConfidentialVmSupported continue to support only CVM and Stateless security profiles
  • The _get_image_tags function now extracts os_type from both Marketplace and Shared Image Gallery images

@kamalca kamalca marked this pull request as ready for review December 11, 2025 22:36
@kamalca kamalca requested a review from LiliDeng as a code owner December 11, 2025 22:36
@paxue
Copy link
Collaborator

paxue commented Dec 11, 2025

I tested this PR and the WSL VM deployed successfully. My scenarios are fully unblocked.

@LiliDeng LiliDeng merged commit 9f32705 into main Dec 12, 2025
64 checks passed
@LiliDeng LiliDeng deleted the kameroncarr/cvm-image branch December 12, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants