Skip to content

Fix CMake version detection for Lagscope installation on different distros #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LiliDeng merged 2 commits into from
Dec 22, 2025
Merged

Fix CMake version detection for Lagscope installation on different distros #4170

LiliDeng merged 2 commits into from
Dec 22, 2025

Conversation

@umfranci
Copy link
Collaborator

@umfranci umfranci commented Dec 22, 2025 •
edited
Loading

  • Lagscope installation fails on certain Distros due to CMake version detection returning malformed output.
  • Changed version extraction code for cleaner shell-side parsing and added Python-side regex validation to extract only a valid X.Y version pattern.
  • Also, set a safe default fallback (3.5) if version detection fails.

@umfranci umfranci requested a review from LiliDeng as a code owner December 22, 2025 12:21
@LiliDeng LiliDeng merged commit 92301af into main Dec 22, 2025
58 checks passed
@LiliDeng LiliDeng deleted the umfranci/lagscope-fix-22122025 branch December 22, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiliDeng LiliDeng LiliDeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@umfranci @LiliDeng