Fix false failures - verify_disks_device_timeout_setting #4190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'verify_disks_device_timeout_setting' is one of the most failed testcases in VM SKU validation with NVMe DCT. Even though 'DiskControllerType.SCSI' a requirement of the testcase, its getting bypassed during the validation. This additional check reduces the total fail count of the test case.
LiliDeng
reviewed
Jan 5, 2026
Collaborator
My recommendation is to check why this is the case. This PR just hides the bug, the same issue could very well happen to a different case with same case requirements. |
LiliDeng
approved these changes
Jan 6, 2026
SRIKKANTH
deleted the
smyakam/verify_disks_device_timeout_setting/04_01_2026
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'verify_disks_device_timeout_setting' is one of the most failed testcases in VM SKU validation with NVMe DCT. Even though 'DiskControllerType.SCSI' a requirement of the testcase, its getting bypassed during the validation. This additional check reduces the total fail count of the test case.