Analyze test coverage for non-marketplace image sanity checks #4220
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LiliDeng requested an analysis of which test cases already contain the logic added in this PR for non-marketplace image sanity checks, and which logic is net new.
Analysis Findings
Logic added in this PR (
lisa/microsoft/testsuites/sanity/sanitysuite.py):/root/.ssh/authorized_keys(≤0o600) and/etc/ssh/sshd_config(≤0o644) permissions/etc/shadowhas no 'others' permissionsExisting similar logic in
lisa/microsoft/testsuites/core/azure_image_standard.py:verify_client_active_interval: SSHClientAliveIntervalconfig validationverify_no_linux_password:/etc/shadowand/etc/passwdparsing, password presence checksNet new logic not in existing tests:
The existing
azure_image_standard.pytests have some overlapping security validations but lack the marketplace detection heuristic and the comprehensive permission-based security posture checks introduced by this PR.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.