Add platform type constraint to passthrough network tests using node_requirement#4267
Merged
Merged
Conversation
…st cases Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update tests to support CLOUD_HYPERVISOR node requirement
Add platform type constraint to passthrough network tests using node_requirement
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four passthrough network performance tests use
node_requirementwithout specifyingsupported_platform_type, while other tests in the same file already restrict toCLOUD_HYPERVISORviasimple_requirement.Changes
supported_platform_type=[CLOUD_HYPERVISOR]tonode_requirement()calls in:perf_tcp_ntttcp_passthrough_host_guestperf_udp_1k_ntttcp_passthrough_host_guestperf_tcp_ntttcp_passthrough_two_guestperf_udp_1k_ntttcp_passthrough_two_guestExample
These tests call
_configure_passthrough_nic_for_node, which requires libvirt-specific passthrough device configuration only available on CLOUD_HYPERVISOR.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.