Skip to content

Add platform type constraint to passthrough network tests using node_requirement#4267

Merged
LiliDeng merged 2 commits into
mainfrom
copilot/update-networkperf-passthrough-tests
Feb 5, 2026
Merged

Add platform type constraint to passthrough network tests using node_requirement#4267
LiliDeng merged 2 commits into
mainfrom
copilot/update-networkperf-passthrough-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 4, 2026

Four passthrough network performance tests use node_requirement without specifying supported_platform_type, while other tests in the same file already restrict to CLOUD_HYPERVISOR via simple_requirement.

Changes

  • Added supported_platform_type=[CLOUD_HYPERVISOR] to node_requirement() calls in:
    • perf_tcp_ntttcp_passthrough_host_guest
    • perf_udp_1k_ntttcp_passthrough_host_guest
    • perf_tcp_ntttcp_passthrough_two_guest
    • perf_udp_1k_ntttcp_passthrough_two_guest

Example

# Before
requirement=node_requirement(
    node=schema.NodeSpace(
        node_count=1,
        memory_mb=search_space.IntRange(min=8192),
    )
)

# After
requirement=node_requirement(
    node=schema.NodeSpace(
        node_count=1,
        memory_mb=search_space.IntRange(min=8192),
    ),
    supported_platform_type=[CLOUD_HYPERVISOR],
)

These tests call _configure_passthrough_nic_for_node, which requires libvirt-specific passthrough device configuration only available on CLOUD_HYPERVISOR.

Original prompt

for any test case in lisa/microsoft/testsuites/performance/networkperf_passthrough.py which has TestCaseMetadata, if it uses _configure_passthrough_nic_for_node, please add supported_platform_type=[CLOUD_HYPERVISOR], in case node_requirement


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…st cases

Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
Copilot AI changed the title [WIP] Update tests to support CLOUD_HYPERVISOR node requirement Add platform type constraint to passthrough network tests using node_requirement Feb 4, 2026
Copilot AI requested a review from LiliDeng February 4, 2026 15:55
@LiliDeng LiliDeng marked this pull request as ready for review February 5, 2026 02:33
@LiliDeng LiliDeng merged commit e7c38af into main Feb 5, 2026
58 checks passed
@LiliDeng LiliDeng deleted the copilot/update-networkperf-passthrough-tests branch February 5, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants