Fix and normalize package path in package_installer validation#4304
Merged
Fix and normalize package path in package_installer validation#4304
Conversation
andrew344c
requested review from
LiliDeng and
johnsongeorge-w
as code owners
LiliDeng
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running LISA with a runbook that uses rpm_package_installer, LISA would fail during the deployment transformer stage (before the test cases even start running) with errors such as:
Root Cause
LISA regression introduced by commit d5f981c.
Before this commit PackageInstaller had no
_initialize()overwrite; this commit introduced it.PackageInstaller started validating RPMs in
_initialize()by calling_validate(), which makes a callself._validate_package(str(directory / file)). On Windows-hosted LISA:str(directory / file)can produce paths like "kernel_source\foo.rpm". Validation then runsrpm -qpon the Linux target and fails with: "Provided file ... is not an rpm".This problem wasn't seen before, likely because
_validate()wasn't on an (regularly) executed code path.Fix
Use correct node-normalized path conversion:
self._node.get_str_path(directory / file).