device_passthrough: skip gracefully when device_pools not configured#4319
Merged
device_passthrough: skip gracefully when device_pools not configured#4319
Conversation
Replace assert with SkippedException so the test skips cleanly on environments that have no device_pools in the runbook, instead of failing with AssertionError.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates device passthrough functional test behavior to skip cleanly when device_pools isn’t configured in the runbook, instead of failing via AssertionError.
Changes:
- Replace an
assertondevice_poolswith a conditional that raisesSkippedException. - Improve compatibility with environments lacking
device_poolsconfiguration.
LiliDeng
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace assert with SkippedException so the test skips cleanly on environments that have no device_pools in the runbook, instead of failing with AssertionError.