Skip to content

add retired VM size SKU block feature#4338

Merged
LiliDeng merged 8 commits intomainfrom
paxue/add_sku_block
Mar 19, 2026
Merged

add retired VM size SKU block feature#4338
LiliDeng merged 8 commits intomainfrom
paxue/add_sku_block

Conversation

@paxue
Copy link
Copy Markdown
Collaborator

@paxue paxue commented Mar 14, 2026

add retired VM size SKU block feature
also support blocked_vm_sizes in yaml

Copilot AI review requested due to automatic review settings March 14, 2026 00:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Azure VM-size blocking mechanism to prevent deployments on Azure-retired SKUs and to support an additional user-configurable blocked_vm_sizes list in the runbook.

Changes:

  • Introduces a hardcoded RETIRED_VM_SIZES blocklist for known retired Azure VM sizes.
  • Extends AzurePlatformSchema with blocked_vm_sizes to allow runbook-based blocking.
  • Filters blocked/retired sizes during capability discovery and raises on explicitly requested blocked sizes.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread lisa/sut_orchestrator/azure/platform_.py Outdated
Comment thread lisa/sut_orchestrator/azure/platform_.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 16, 2026 23:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Azure VM size blocking to prevent deployments using retired SKUs and allow additional user-configured blocked sizes via the Azure platform runbook. This fits into LISA’s Azure platform capability selection flow by filtering disallowed sizes before capability/quota evaluation.

Changes:

  • Introduces a hardcoded RETIRED_VM_SIZES block list for known retired Azure SKUs.
  • Adds blocked_vm_sizes to AzurePlatformSchema to support YAML-configured blocking.
  • Filters retired/blocked VM sizes during _get_allowed_capabilities, with a hard error when an explicit vm_size request is fully blocked.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread lisa/sut_orchestrator/azure/platform_.py Outdated
Comment thread lisa/sut_orchestrator/azure/platform_.py Outdated
paxue and others added 2 commits March 16, 2026 16:50
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 16, 2026 23:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Azure VM-size blocking mechanism to prevent deployments on Azure-retired SKUs and to support user-configured blocked SKUs via runbook YAML, improving reliability of environment provisioning.

Changes:

  • Introduces a hardcoded RETIRED_VM_SIZES denylist for Azure-retired VM SKUs.
  • Adds blocked_vm_sizes to AzurePlatformSchema to allow runbook-configured VM-size blocking.
  • Filters allowed VM sizes during capability selection and skips when an explicitly requested VM size is blocked/retired.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread lisa/sut_orchestrator/azure/platform_.py
Comment thread lisa/sut_orchestrator/azure/platform_.py Outdated
Comment thread lisa/sut_orchestrator/azure/platform_.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 17, 2026 00:29
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 17, 2026

@paxue I've opened a new pull request, #4344, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Azure VM-size blocking mechanism so LISA won’t attempt deployments using Azure-retired SKUs, and also allows runbook-driven blocking of additional VM sizes.

Changes:

  • Introduces a hardcoded RETIRED_VM_SIZES denylist for known retired Azure VM sizes.
  • Extends AzurePlatformSchema to accept blocked_vm_sizes from YAML.
  • Filters allowed_vm_sizes during capability discovery to exclude retired/blocked sizes and skip deployments when a user-requested size is blocked.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread lisa/sut_orchestrator/azure/platform_.py
@LiliDeng LiliDeng merged commit dde644f into main Mar 19, 2026
58 checks passed
@LiliDeng LiliDeng deleted the paxue/add_sku_block branch March 19, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants