Conversation
There was a problem hiding this comment.
Pull request overview
Adds an Azure VM-size blocking mechanism to prevent deployments on Azure-retired SKUs and to support an additional user-configurable blocked_vm_sizes list in the runbook.
Changes:
- Introduces a hardcoded
RETIRED_VM_SIZESblocklist for known retired Azure VM sizes. - Extends
AzurePlatformSchemawithblocked_vm_sizesto allow runbook-based blocking. - Filters blocked/retired sizes during capability discovery and raises on explicitly requested blocked sizes.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds Azure VM size blocking to prevent deployments using retired SKUs and allow additional user-configured blocked sizes via the Azure platform runbook. This fits into LISA’s Azure platform capability selection flow by filtering disallowed sizes before capability/quota evaluation.
Changes:
- Introduces a hardcoded
RETIRED_VM_SIZESblock list for known retired Azure SKUs. - Adds
blocked_vm_sizestoAzurePlatformSchemato support YAML-configured blocking. - Filters retired/blocked VM sizes during
_get_allowed_capabilities, with a hard error when an explicitvm_sizerequest is fully blocked.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds an Azure VM-size blocking mechanism to prevent deployments on Azure-retired SKUs and to support user-configured blocked SKUs via runbook YAML, improving reliability of environment provisioning.
Changes:
- Introduces a hardcoded
RETIRED_VM_SIZESdenylist for Azure-retired VM SKUs. - Adds
blocked_vm_sizestoAzurePlatformSchemato allow runbook-configured VM-size blocking. - Filters allowed VM sizes during capability selection and skips when an explicitly requested VM size is blocked/retired.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds an Azure VM-size blocking mechanism so LISA won’t attempt deployments using Azure-retired SKUs, and also allows runbook-driven blocking of additional VM sizes.
Changes:
- Introduces a hardcoded
RETIRED_VM_SIZESdenylist for known retired Azure VM sizes. - Extends
AzurePlatformSchemato acceptblocked_vm_sizesfrom YAML. - Filters
allowed_vm_sizesduring capability discovery to exclude retired/blocked sizes and skip deployments when a user-requested size is blocked.
You can also share your feedback on Copilot code review. Take the survey.
add retired VM size SKU block feature
also support blocked_vm_sizes in yaml