BugFix: Skip azsecpack test for unsupported distros#4345
Merged
Conversation
The _is_supported() method only rejected known distros with wrong versions but silently allowed distros not in the supported list (e.g. SLES on ARM64). Added early return for valid distro+version and a fallthrough SkippedException for unlisted distros.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes AzSecPack’s distro support gating so the test is skipped (instead of silently proceeding) when the OS distro isn’t in the supported list (notably impacting unsupported combinations like SLES on ARM64).
Changes:
- Return early from
_is_supported()when the distro+major version is explicitly supported. - Add a fallthrough
SkippedException(UnsupportedDistroException(...))when the distro is not in the supported list.
You can also share your feedback on Copilot code review. Take the survey.
LiliDeng
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _is_supported() method only rejected known distros with wrong versions but silently allowed distros not in the supported list (e.g. SLES on ARM64). Added early return for valid distro+version and a fallthrough SkippedException for unlisted distros.