Skip to content

mshv: remove CHK dependency from crash test#4346

Merged
LiliDeng merged 1 commit intomainfrom
vyadav/mshv_crash
Mar 19, 2026
Merged

mshv: remove CHK dependency from crash test#4346
LiliDeng merged 1 commit intomainfrom
vyadav/mshv_crash

Conversation

@vyadavmsft
Copy link
Copy Markdown
Collaborator

We do not need chk build anymore for crash.

@vyadavmsft vyadavmsft requested a review from LiliDeng as a code owner March 17, 2026 20:02
Copilot AI review requested due to automatic review settings March 17, 2026 20:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the MSHV root crash test by removing the requirement to provide and install CHK hypervisor binaries, and instead relying on the normal (FRE) environment while ensuring lockdown=integrity doesn’t block the crash trigger path.

Changes:

  • Removes CHK binary/loader variables and the associated remote copy/extract/install flow.
  • Adds logic to detect and remove lockdown=integrity from the dom0 boot configuration and reboot if needed.
  • Cleans up imports accordingly.

Comment thread lisa/microsoft/testsuites/mshv/mshv_root_tests.py
Comment thread lisa/microsoft/testsuites/mshv/mshv_root_tests.py Outdated
Comment thread lisa/microsoft/testsuites/mshv/mshv_root_tests.py
Comment thread lisa/microsoft/testsuites/mshv/mshv_root_tests.py
Copilot AI review requested due to automatic review settings March 17, 2026 22:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MSHV root partition crash validation to no longer depend on providing external CHK hypervisor binaries, simplifying how the crash test is executed in the LISA MSHV test suite.

Changes:

  • Removed CHK-binary copy/extract/installation flow and the associated required testcase variables.
  • Updated the crash test flow to ensure lockdown=integrity is removed (via GRUB edit + reboot when needed) before triggering the hvdbg crash and validating kdump output.

Comment thread lisa/microsoft/testsuites/mshv/mshv_root_tests.py Outdated
Comment thread lisa/microsoft/testsuites/mshv/mshv_root_tests.py
Copilot AI review requested due to automatic review settings March 17, 2026 23:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MSHV root-partition crash validation to remove the dependency on external CHK hypervisor binary artifacts, and instead triggers the crash using the regular (FRE) hypervisor build after ensuring lockdown=integrity isn’t preventing access to the hvdbg debugfs trigger.

Changes:

  • Removed CHK binary/loader copy & extraction flow (and associated test variables) from the crash test.
  • Added logic to detect and remove lockdown=integrity from the dom0 GRUB config and reboot if needed before triggering hvdbg.
  • Simplified imports and crash-test description to reflect the new approach.

@vyadavmsft
Copy link
Copy Markdown
Collaborator Author

@LiliDeng pls check

@LiliDeng LiliDeng merged commit 50f7881 into main Mar 19, 2026
58 checks passed
@LiliDeng LiliDeng deleted the vyadav/mshv_crash branch March 19, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants