ch: disable LISA hugepage setup in perf-stable mode#4352
Merged
vyadavmsft merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Disables LISA-side hugepage reservation during Cloud Hypervisor perf-stable runs, delegating hugepage setup to the Cloud Hypervisor harness to avoid duplicated/competing host configuration.
Changes:
- Removed hugepage reservation (1GB with 2MB fallback) from perf-stable host setup in
CloudHypervisorTests._setup_host_perf_policies(). - Updated the perf-stable policy description to no longer list hugepage reservation as a LISA-managed policy.
anirudhrb
approved these changes
Mar 19, 2026
Collaborator
anirudhrb
left a comment
anirudhrb
left a comment
There was a problem hiding this comment.
Just curious, what's the reason for disabling? Was it conflicting with some Cloud Hypervisor tests or was it not giving us much gains?
Collaborator
Author
|
@anirudhrb it was not giving gains , CH test were setting hugepage and LISA was also setting. so its better CH manage hugepage and we dont intefer . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable LISA-side hugepage configuration for Cloud Hypervisor perf runs and leave hugepage setup to the Cloud Hypervisor harness.