Skip to content

variables: allow env var to set case visible variables#4354

Merged
LiliDeng merged 1 commit intomainfrom
mcgov/case-visible-env
Mar 19, 2026
Merged

variables: allow env var to set case visible variables#4354
LiliDeng merged 1 commit intomainfrom
mcgov/case-visible-env

Conversation

@mcgov
Copy link
Copy Markdown
Collaborator

@mcgov mcgov commented Mar 18, 2026

Allows setting a case visible variable from the environment. This adds the ability to set the is_case_visible flag (similar to the default and is_secret flags).

Copilot AI review requested due to automatic review settings March 18, 2026 23:15
@mcgov mcgov force-pushed the mcgov/case-visible-env branch from 6f082dc to 152b7cb Compare March 18, 2026 23:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends LISA’s environment-variable-based variable loading to support marking variables as case-visible (i.e., surfaced to test cases) via a dedicated CV_LISA_ prefix, similar to existing secret variable support.

Changes:

  • Add CV_LISA_ environment variable prefix support.
  • Propagate is_case_visible=True when loading variables from the environment using the new prefix.

Comment thread lisa/variable.py
@mcgov mcgov force-pushed the mcgov/case-visible-env branch from 152b7cb to f7b059e Compare March 18, 2026 23:24
@mcgov mcgov marked this pull request as ready for review March 18, 2026 23:57
Copilot AI review requested due to automatic review settings March 18, 2026 23:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables setting case-visible variables via environment variables, aligning env-based variable configuration with existing secret (S_LISA_) support so values can be surfaced to test cases through case_variables.

Changes:

  • Add a new environment variable prefix CV_LISA_ for variables that should be exposed to test cases (is_case_visible=True).
  • Extend _load_from_env() to plumb the new is_case_visible flag into _add_variable().

Comment thread lisa/variable.py
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 19, 2026

@mcgov I've opened a new pull request, #4356, to work on those changes. Once the pull request is ready, I'll request review from you.

@LiliDeng LiliDeng merged commit bf97427 into main Mar 19, 2026
62 checks passed
@LiliDeng LiliDeng deleted the mcgov/case-visible-env branch March 19, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants