Use NETVSC_RECV/SEND_SECTION_SIZE constants instead of hardcoded values throughout ring buffer verification#4366
Merged
LiliDeng merged 3 commits intobugfix/ringbuffer-tolerance-64k-page_190326_133123from Mar 20, 2026
Conversation
…nts throughout Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on using NETVSC section sizes instead of hardcoded values
Use NETVSC_RECV/SEND_SECTION_SIZE constants instead of hardcoded values throughout ring buffer verification
Mar 20, 2026
Collaborator
|
@copilot please fix the CI error |
…formatting (BLK100) Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
Contributor
Author
LiliDeng
approved these changes
Mar 20, 2026
a777f53
into
bugfix/ringbuffer-tolerance-64k-page_190326_133123
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All ring buffer calculations in
verify_ring_buffer_settingsused hardcoded1728/6144even afterNETVSC_RECV_SECTION_SIZE/NETVSC_SEND_SECTION_SIZEconstants were introduced, creating drift risk between tolerance computation and buffer size math.Changes
1728→NETVSC_RECV_SECTION_SIZEand6144→NETVSC_SEND_SECTION_SIZEin:original_rxbuffer/original_txbuffer(sections → MB conversion)expected_rx/expected_tx(MB → sections conversion)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.