passthrough: add generic device pool identifiers#4369
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the host device pool schema and passthrough pool configuration to support Hyper-V location_path identifiers in addition to vendor/device IDs and PCI BDF lists, centralizing parsing/validation and filtering blank entries.
Changes:
- Added a
DeviceLocationPathIdentifierschema and expandedHostDevicePoolSchema.devicesto accept it. - Refactored passthrough pool configuration to normalize/validate identifier inputs in one place.
- Added normalization logic to strip/ignore blank string entries in configured string lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lisa/sut_orchestrator/util/schema.py | Adds a new location-path identifier dataclass and extends the device pool schema union to include it. |
| lisa/sut_orchestrator/util/device_pool.py | Refactors passthrough configuration to route identifier types through centralized normalization/validation, and adds location-path plumbing. |
vyadavmsft
force-pushed
the
vyadav_hyperv_pass1
branch
from
2f63ea7 to
ea5126c
Compare
vyadavmsft
force-pushed
the
vyadav_hyperv_pass1
branch
from
ea5126c to
740005d
Compare
vyadavmsft
force-pushed
the
vyadav_hyperv_pass1
branch
from
740005d to
d517dd1
Compare
Extend host device pool schema to accept Hyper-V location_path identifiers alongside vendor/device IDs and pci_bdf lists. Refactor BaseDevicePool passthrough pool configuration so identifier-based inputs are normalized and validated in one place, and ignore blank string entries while parsing configured string lists. This commit adds the generic plumbing only. Platform-specific Hyper-V and libvirt consumers are added in later commits.
vyadavmsft
force-pushed
the
vyadav_hyperv_pass1
branch
from
d517dd1 to
bbfff5f
Compare
LiliDeng
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend host device pool schema to accept Hyper-V location_path identifiers alongside vendor/device IDs and pci_bdf lists.
Refactor BaseDevicePool passthrough pool configuration so identifier-based inputs are normalized and validated in one place, and ignore blank string entries while parsing configured string lists.
This commit adds the generic plumbing only.
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_device_passthrough_on_guest
Impacted LISA Features:
Network Passthrough
Tested Azure Marketplace Images:
Dom0 Local HYper-V VHD
Test Results
| Image | VM Size | Result |
|--Dom0----|-Local VM----|--------|
| | | PASSED |