Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Hyper-V host device passthrough pool enhancements, aiming to support selecting DDA devices by Hyper-V LocationPath and improving robustness around PowerShell command handling.
Changes:
- Add Hyper-V device pool APIs intended for
location_path-based pool creation, including host-side “reclaim/restore” helpers. - Improve PowerShell quoting/escaping for VM names, location paths, and instance IDs when assigning/releasing devices.
- Refactor DDA device discovery logic (MMIO parsing, device eligibility checks) and add discovery by location path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lisa/sut_orchestrator/hyperv/hyperv_device_pool.py | Adds location-path pool entry point + host restore logic; improves escaping and error handling in pool/device operations. |
| lisa/sut_orchestrator/hyperv/get_assignable_devices.py | Adds location-path based assignable device lookup; refactors DDA eligibility checks and MMIO parsing/validation. |
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
b8ebea2 to
64e1c9f
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
64e1c9f to
b444154
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
b444154 to
41d47c1
Compare
anirudhrb
requested changes
Mar 21, 2026
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
41d47c1 to
37e15b6
Compare
anirudhrb
requested changes
Mar 23, 2026
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
37e15b6 to
233e77c
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
233e77c to
9f77c3c
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
9f77c3c to
3199f18
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
cb86ec8 to
dfbf406
Compare
Add Hyper-V DDA discovery by location path and refactor assignable-device checks into smaller helpers. This commit teaches the assignable device helper to enumerate present PCI devices with location paths, resolve requested location_path values back to assignable DDA devices, and tighten MMIO parsing and device eligibility checks. Pool integration is added in the next commit.
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
dfbf406 to
2811bc4
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
2811bc4 to
438b0e0
Compare
anirudhrb
requested changes
Mar 25, 2026
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
438b0e0 to
6cbf607
Compare
vyadavmsft
force-pushed
the
vyadav_pass2
branch
from
6cbf607 to
0a5e570
Compare
anirudhrb
approved these changes
Mar 25, 2026
LiliDeng
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_device_passthrough_on_guest
Impacted LISA Features:
NIC Passthrough
Tested Azure Marketplace Images:
-Local VHD
Test Results
verify_device_passthrough_on_guest