Conversation
vyadavmsft
requested review from
LiliDeng,
johnsongeorge-w and
lubaihua33
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens cleanup and reduces log noise in the network passthrough performance test suite, with additional guarding to avoid invalid cleanup paths on unsupported Windows baremetal hosts.
Changes:
- Downgrade passthrough NIC selection logs from
infotodebugto reduce noise. - Initialize the baremetal host node early and explicitly skip host/guest passthrough perf runs when the host is Windows.
- Make
after_casecleanup more robust by skipping sysctl reset on Windows and using a PowerShell-based process stop path when needed.
lisa/microsoft/testsuites/performance/networkperf_passthrough.py
Outdated
Show resolved
Hide resolved
Reduce noisy passthrough NIC selection logs and harden host/guest cleanup for network passthrough performance runs. This commit skips unsupported Windows baremetal hosts for passthrough network performance, uses PowerShell-based process cleanup where needed, and avoids sysctl or Kill-tool cleanup paths that are not valid on Windows baremetal nodes.
vyadavmsft
force-pushed
the
vyadav_pass4
branch
from
3ddb8a4 to
b89a0e2
Compare
Collaborator
Author
|
@LiliDeng pls check |
LiliDeng
reviewed
Mar 26, 2026
LiliDeng
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce noisy passthrough NIC selection logs and harden host/guest cleanup for network passthrough performance runs.
This commit skips unsupported Windows baremetal hosts for passthrough network performance, uses PowerShell-based process cleanup where needed, and avoids sysctl or Kill-tool cleanup paths that are not valid on Windows baremetal nodes.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_device_passthrough_on_guest
Impacted LISA Features:
NIC Passthrough
Tested Azure Marketplace Images:
Local HYperV VHD
Test Results
verify_device_passthrough_on_guest