Skip to content

[AI Generated] BugFix: Skip verify_sgx test on non-x64 architectures#4374

Merged
LiliDeng merged 1 commit intomainfrom
bugfix/sgx-skip-arm64_200326_224808
Mar 23, 2026
Merged

[AI Generated] BugFix: Skip verify_sgx test on non-x64 architectures#4374
LiliDeng merged 1 commit intomainfrom
bugfix/sgx-skip-arm64_200326_224808

Conversation

@johnsongeorge-w
Copy link
Copy Markdown
Collaborator

Summary

Add an x86_64 architecture guard to the verify_sgx test case in ACCBasicTest. SGX is an Intel-only feature and the test should be skipped on ARM64 VMs instead of failing with a 404 when downloading the x64 Intel SGX driver.

The fix checks the CPU architecture using Lscpu.get_architecture() at the start of verify_sgx() and raises SkippedException(UnsupportedCpuArchitectureException(...)) for non-x64 architectures, following the same pattern used in DPDK and other LISA test suites.

Validation Results

Image VM Size Location Result
Canonical 0001-com-ubuntu-server-focal 20_04-lts-gen2 latest Standard_DC2s_v3 eastus2 PASSED
Canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest Standard_D2pds_v5 eastus2 SKIPPED (no ACC feature on ARM64 - correct)

Copilot AI review requested due to automatic review settings March 21, 2026 06:08
@johnsongeorge-w
Copy link
Copy Markdown
Collaborator Author

Validation Results

Image VM Size Location Result
Canonical 0001-com-ubuntu-server-focal 20_04-lts-gen2 latest Standard_DC2s_v3 eastus2 PASSED
Canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest Standard_D2pds_v5 eastus2 SKIPPED (no ACC feature on ARM64 - correct)
Canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest Standard_DC2s_v3 eastus2 FAILED (pre-existing package issue: clang-10, libprotobuf17, open-enclave unavailable on Jammy - unrelated to this fix)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an architecture guard to the ACC SGX BVT so the verify_sgx test is skipped on non-x64 machines (e.g., ARM64), preventing failures caused by downloading x64-only SGX components.

Changes:

  • Detect CPU architecture via Lscpu.get_architecture() at the start of verify_sgx.
  • Skip the test on non-x64 by raising SkippedException(UnsupportedCpuArchitectureException(...)).

@LiliDeng LiliDeng merged commit d20c7c3 into main Mar 23, 2026
62 checks passed
@LiliDeng LiliDeng deleted the bugfix/sgx-skip-arm64_200326_224808 branch March 23, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants