Skip to content

Set test tags as 'VM Extension Cases' for extension cases#4383

Merged
LiliDeng merged 3 commits intomainfrom
lildeng/update_tags
Mar 24, 2026
Merged

Set test tags as 'VM Extension Cases' for extension cases#4383
LiliDeng merged 3 commits intomainfrom
lildeng/update_tags

Conversation

@LiliDeng
Copy link
Copy Markdown
Collaborator

@LiliDeng LiliDeng commented Mar 23, 2026

Description

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • Description is filled in above
  • No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

Key Test Cases:

Impacted LISA Features:

Tested Azure Marketplace Images:

Test Results

Image VM Size Result
PASSED / FAILED / SKIPPED

Copilot AI review requested due to automatic review settings March 23, 2026 12:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a consistent tags=["VM Extension Cases"] label to VM extension test suites/cases so they can be selected via tag-based criteria, and updates the docs metadata extractor to understand list-valued decorator arguments (needed for tags=).

Changes:

  • Add tags=["VM Extension Cases"] to VM extension @TestSuiteMetadata decorators across the vm_extensions test suites.
  • Update docs/tools/doc_generator.py to extract decorator keyword values via helpers, including support for ast.List (so list-valued metadata like tags doesn’t break doc generation).

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lisa/microsoft/testsuites/vm_extensions/waagent.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/vmsnapshot_extension.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/runtime_extensions/vmaccess.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/runtime_extensions/run_commandv2.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/runtime_extensions/run_commandv1.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/runtime_extensions/custom_script.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/networkwatcherextension.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/mdm.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/linux_patch_extension.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/cvt.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/azureperformancediagnostics.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/azure_keyvault_vm_extension.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/azure_disk_encryption.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/azsecpack.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/applicationhealthextension.py Adds VM extension tag to suite metadata.
lisa/microsoft/testsuites/vm_extensions/AzureMonitorAgentLinux.py Adds VM extension tag to suite metadata.
docs/tools/doc_generator.py Adds list extraction + refactors decorator param extraction into helpers to support tags=[...].

Comment thread lisa/microsoft/testsuites/vm_extensions/waagent.py Outdated
@johnsongeorge-w
Copy link
Copy Markdown
Collaborator

Nit: Consider using underscores instead of spaces in the tag — VM_Extension_Cases instead of VM Extension Cases. This avoids potential quoting issues in YAML runbook criteria and CLI arguments. Not a blocker.

lubaihua33
lubaihua33 previously approved these changes Mar 24, 2026
@LiliDeng
Copy link
Copy Markdown
Collaborator Author

@copilot please update tags=['VM_Extension'], and revert changes for docs/tools/doc_generator.py‎

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

@LiliDeng I've opened a new pull request, #4387, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits March 24, 2026 19:37
@LiliDeng LiliDeng dismissed stale reviews from lubaihua33 and johnsongeorge-w via f8c325c March 24, 2026 11:37
@LiliDeng LiliDeng merged commit b1bdcad into main Mar 24, 2026
58 checks passed
@LiliDeng LiliDeng deleted the lildeng/update_tags branch March 24, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants