[AI Generated] BugFix: Fix verify_sriov_reload_modules failure on HPC images with broken mana_ib#4449
Merged
LiliDeng merged 1 commit intoMay 11, 2026
Conversation
… images with broken mana_ib unload_module() used module_exists() (modprobe --dry-run) to filter the driver list before unloading. On AlmaLinux 9 HPC, mana_ib.ko exists on disk but was never loaded at boot due to symbol version mismatches with IB core. The test then tried to reload mana_ib, failing with EINVAL. Change the filter from module_exists() to is_module_loaded() so only modules that are actually loaded get unloaded and subsequently reloaded. Also fix a secondary bug: module_name_list was declared outside the node loop, causing all nodes to share the same growing list reference.
LiliDeng
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix verify_sriov_reload_modules failing on HPC images where mana_ib.ko exists but cannot load due to kernel symbol mismatches. Changed unload_module() to use is_module_loaded() instead of module_exists() so only actually-loaded modules are included in the unload/reload list. Also fixed module_name_list not being reset per node.
Validation Results