Fix vdso compilation issues on Ubuntu2510#4452
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Vdsotest tool’s source-build configuration to force a consistent C standard across distros, preventing build failures on newer GCC toolchains (e.g., Ubuntu 25.10) where C23 reserves nullptr.
Changes:
- Always pass
CFLAGS=-std=gnu11to./configurewhen building vdsotest from source (previously Fedora-only).
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
kanchansenlaskar
approved these changes
May 3, 2026
LiliDeng
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use -std=gnu11 to avoid compilation errors on newer GCC versions that default to C23, where 'nullptr' is a reserved keyword conflicting with the vdsotest source code (src/getcpu.c). This is the solution already used for Fedora, but can be used for all distros without any issue.
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_vdso
Impacted LISA Features:
Tested Azure Marketplace Images:
almalinux almalinux-x86_64 9-gen2 latest
canonical 0001-com-ubuntu-pro-microsoft 18_04-lts latest
canonical 0001-com-ubuntu-pro-microsoft 18_04-lts-arm64 latest
canonical 0001-com-ubuntu-pro-microsoft 18_04-lts-gen1 latest
canonical 0001-com-ubuntu-pro-microsoft pro-fips-18_04 latest
canonical 0001-com-ubuntu-pro-microsoft pro-fips-20_04 latest
canonical 0001-com-ubuntu-pro-microsoft pro-fips-22_04 latest
canonical 0001-com-ubuntu-pro-microsoft pro-fips-22_04-arm64 latest
canonical 0001-com-ubuntu-pro-microsoft pro-fips-22_04-gen1 latest
canonical 0001-com-ubuntu-server-focal 20_04-lts latest
canonical 0001-com-ubuntu-server-focal 20_04-lts-arm64 latest
canonical 0001-com-ubuntu-server-focal 20_04-lts-gen2 latest
canonical 0001-com-ubuntu-server-jammy 22_04-lts latest
canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest
canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
canonical ubuntu-24_04-lts server latest
canonical ubuntu-24_04-lts server-arm64 latest
canonical ubuntu-24_04-lts server-gen1 latest
canonical ubuntu-25_04 server latest
canonical ubuntu-25_04 server-arm64 latest
canonical ubuntu-25_04 server-gen1 latest
canonical ubuntu-25_10 server latest
canonical ubuntu-25_10 server-arm64 latest
canonical ubuntu-25_10 server-gen1 latest
canonical ubuntuserver 16_04-lts-gen2 latest
canonical ubuntuserver 16.04-lts latest
debian debian-12 12-gen2 latest
microsoftcblmariner azure-linux-3 azure-linux-3-gen2 latest
microsoftcblmariner cbl-mariner cbl-mariner-2-gen2 latest
oracle oracle-linux ol95-lvm-gen2 latest
redhat rhel 10-lvm-gen2 latest
redhat rhel 101-gen2 latest
resf rockylinux-x86_64 9-base latest
suse sles-sap-15-sp7 gen2 latest
Test Results