libvirt: add auto-discovery support for device passthrough pools#4465
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an auto_discover flag to host device pool configuration so libvirt-backed device passthrough pools can be discovered automatically when explicit device identifiers aren’t provided.
Changes:
- Extend
HostDevicePoolSchemawithauto_discover: bool. - Update passthrough pool configuration path to support an auto-discovery workflow.
- Implement libvirt-specific auto-discovery and pool creation from discovered candidates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lisa/sut_orchestrator/util/schema.py | Adds auto_discover flag to device pool schema. |
| lisa/sut_orchestrator/util/device_pool.py | Routes passthrough pool configuration to auto-discovery and introduces a base auto_discover_pool hook. |
| lisa/sut_orchestrator/libvirt/libvirt_device_pool.py | Implements auto-discovery for libvirt pools and creates pools from discovered candidates. |
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
|
@vyadavmsft @anirudhrb please review, thanks. |
|
@pupacha changes looks fine but can you test this too. Just to make sure this works as intended and not break exisiting test. we can work offline to test. |
vyadavmsft
left a comment
There was a problem hiding this comment.
lets test is first, if its working as intended.
|
@pupacha please provide the test results. |
Add a new flag in HostDevicePoolSchema to let lisa auto discover the device pool.
1887f87 to
8e1ebdb
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
Description
Add a new flag in HostDevicePoolSchema to let lisa auto discover the device pool.
Related Issue
None
Type of Change
Checklist
Test Validation
N/A
Test Results
N/A