Skip to content

libvirt: add auto-discovery support for device passthrough pools#4465

Merged
pupacha merged 1 commit into
mainfrom
pavan/auto_discover
May 19, 2026
Merged

libvirt: add auto-discovery support for device passthrough pools#4465
pupacha merged 1 commit into
mainfrom
pavan/auto_discover

Conversation

@pupacha
Copy link
Copy Markdown
Collaborator

@pupacha pupacha commented May 5, 2026

Description

Add a new flag in HostDevicePoolSchema to let lisa auto discover the device pool.

Related Issue

None

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • Description is filled in above
  • No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

N/A

Test Results

N/A

Copilot AI review requested due to automatic review settings May 5, 2026 17:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an auto_discover flag to host device pool configuration so libvirt-backed device passthrough pools can be discovered automatically when explicit device identifiers aren’t provided.

Changes:

  • Extend HostDevicePoolSchema with auto_discover: bool.
  • Update passthrough pool configuration path to support an auto-discovery workflow.
  • Implement libvirt-specific auto-discovery and pool creation from discovered candidates.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
lisa/sut_orchestrator/util/schema.py Adds auto_discover flag to device pool schema.
lisa/sut_orchestrator/util/device_pool.py Routes passthrough pool configuration to auto-discovery and introduces a base auto_discover_pool hook.
lisa/sut_orchestrator/libvirt/libvirt_device_pool.py Implements auto-discovery for libvirt pools and creates pools from discovered candidates.

Comment thread lisa/sut_orchestrator/util/schema.py
Comment thread lisa/sut_orchestrator/util/device_pool.py
Comment thread lisa/sut_orchestrator/libvirt/libvirt_device_pool.py
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

✅ AI Test Selection — PASSED

1 test case(s) selected (view run)

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Count
✅ Passed 1
❌ Failed 0
⏭️ Skipped 0
Total 1
Test case details
Test Case Status Time (s) Message
smoke_test (lisa_0_0) ✅ PASSED 42.219

@LiliDeng
Copy link
Copy Markdown
Collaborator

LiliDeng commented May 7, 2026

@vyadavmsft @anirudhrb please review, thanks.

@vyadavmsft
Copy link
Copy Markdown
Collaborator

@pupacha changes looks fine but can you test this too. Just to make sure this works as intended and not break exisiting test. we can work offline to test.

Copy link
Copy Markdown
Collaborator

@vyadavmsft vyadavmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets test is first, if its working as intended.

@LiliDeng
Copy link
Copy Markdown
Collaborator

@pupacha please provide the test results.

Add a new flag in HostDevicePoolSchema to let lisa auto discover the
device pool.
@pupacha pupacha force-pushed the pavan/auto_discover branch from 1887f87 to 8e1ebdb Compare May 14, 2026 06:43
@github-actions
Copy link
Copy Markdown

✅ AI Test Selection — PASSED

1 test case(s) selected (view run)

Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest

Count
✅ Passed 1
❌ Failed 0
⏭️ Skipped 0
Total 1
Test case details
Test Case Status Time (s) Message
smoke_test (lisa_0_0) ✅ PASSED 38.415

@vyadavmsft vyadavmsft self-requested a review May 19, 2026 18:26
@pupacha pupacha merged commit c3ce365 into main May 19, 2026
61 checks passed
@pupacha pupacha deleted the pavan/auto_discover branch May 19, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants