lspci: use controller_id for NVMe discovery, exclude ASAP by device_id#4468
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors PCI/NVMe discovery in Lspci to identify NVMe devices by their controller ID (0108) rather than maintaining an ever-growing allowlist of NVMe device IDs, while explicitly filtering out ASAP devices by device ID to avoid misclassification.
Changes:
- Switch NVMe discovery in
get_device_names_by_type/get_devices_by_typeto rely on controller IDs instead of NVMe device IDs. - Exclude ASAP devices during controller-based discovery by filtering known ASAP device IDs.
✅ AI Test Selection — PASSED4 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
Previosuly, NVMe devices are discovered filtering on the device id maintained in DEVICE_ID_DICT. This was because both NVMe and ASAP device have same controller (0108). But this approach mandates, every kind of nvme device id to be added into the DEVICE_ID_DICT which is not scalable. Instead, fetch the devices using the nvme controller itself and then filter out the ASAP devices based on its device id.
✅ AI Test Selection — PASSED4 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
LiliDeng
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previosuly, NVMe devices are discovered filtering on the device id maintained in DEVICE_ID_DICT. This was because both NVMe and ASAP device have same controller (0108). But this approach mandates, every kind of nvme device id to be added into the DEVICE_ID_DICT which is not scalable.
Instead, fetch the devices using the nvme controller itself and then filter out the ASAP devices based on its device id.
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results