[AI Generated] BugFix: install build-essential for lagscope source build on Debian#4486
Merged
Merged
Conversation
On minimal Debian-family cloud images (e.g., Ubuntu 25.10 arm64), the base image lacks a complete C toolchain. The lagscope tool depends on Git/Make/Gcc but the Debian dep list omits 'build-essential', which can lead to silent build failures where 'do-cmake.sh build' returns success but lagscope binary is not produced/installed, causing the post-install detection to fail with: 'install lagscope failed. After installed, it cannot be detected.' Add 'build-essential' to the Debian package_list, matching the netperf fix in PR #4485.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds missing build toolchain dependencies so lagscope can be built successfully from source on minimal Debian/Ubuntu images.
Changes:
- Add
build-essentialto the Debian-family dependency list forlagscopeinstallation.
johnsongeorge-w
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On minimal Debian-family cloud images (e.g., Ubuntu 25.10 arm64
canonical ubuntu-25_10 server-arm64 25.10.202601100), theLagscopetool fails to install with:The Debian dep list
[libaio1, sysstat, cmake]is missingbuild-essential. TheGit/Make/Gcctool dependencies pull in individual packages, but on minimal cloud images a full C toolchain (linker, glibc headers, etc.) is not present, leading to silent build failures fromdo-cmake.sh build.Fix
Add
build-essentialto the Debianpackage_listinLagscope._install_dep_packages(). Same pattern as PR #4485 (netperf).Validation
canonical ubuntu-25_10 server-arm64 25.10.202601100runningXdpPerformance.perf_xdp_lagscope_latencyonStandard_D8ps_v5.This pull request was authored with the assistance of an AI agent (GitHub Copilot).