verify_os_update - mark node dirty after OS update#4509
Merged
Conversation
After OS update sometimes kernel version may change. When LISA is used to validate a VM image with specific kernel version, changing the kernel will result in running tests with undesired kernel which should be avoided. Marking the node dirty after OS update to avoid such issues.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the verify_os_update Azure image validation test to ensure that if an OS package update changes the kernel version, the node is marked dirty so it won’t be reused by subsequent test cases that may require the original kernel/version state.
Changes:
- Mark the node dirty after
update_packages()to prevent reusing a potentially kernel-changed VM for later validations. - Move the reboot call into the POSIX branch so it only happens when the update actually runs.
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
LiliDeng
reviewed
Jun 2, 2026
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
LiliDeng
approved these changes
Jun 2, 2026
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After OS update sometimes kernel version may change. When LISA is used to validate a VM image with specific kernel version, changing the kernel will result in running tests with undesired kernel which should be avoided. Marking the node dirty after OS update to avoid such issues.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_os_update
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results