Support metadata for network north interfaces#169
Conversation
Co-authored-by: jaybosamiya-ms <171180729+jaybosamiya-ms@users.noreply.github.com>
jaybosamiya-ms
left a comment
There was a problem hiding this comment.
Some changes are needed. Comments inline.
Top level comments:
- Make sure to run
cargo fmt. - FD-specific metadata requires coordination with #120 and #31, so should not be done as part of this PR. This also means that this does not lead to #119 being closed as done, but instead only completes a part of it. This is fine, the rest of it should be done as a separate PR anyways.
… metadata - Remove InvalidFd from MetadataError and SetMetadataError - Remove fd_metadata field from SocketHandle - Remove set_fd_metadata method entirely - Update metadata methods to only work with socket_metadata - Remove test_fd_metadata and test_metadata_priority tests - Add TODO comments linking to #120 and #31 for future FD-specific metadata - Keep SetMetadataError as non-exhaustive but empty enum with phantom type Co-authored-by: jaybosamiya-ms <171180729+jaybosamiya-ms@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
jaybosamiya-ms
left a comment
There was a problem hiding this comment.
Thanks, mostly looks good, minor suggestions. Please also make sure to run cargo fmt on the workspace, thanks!
Co-authored-by: jaybosamiya-ms <171180729+jaybosamiya-ms@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
jaybosamiya-ms
left a comment
There was a problem hiding this comment.
This PR should have also been largely straightforward for Copilot to do, but seemed to require a little more hand-holding. Part of it is that I mildly sent it down a tiny tangent, which I asked it to then revert, but the revert did not work out as well as I'd have liked.
Anyways, I've now manually fixed up the code needed for it. I don't know if I can say that this one in particular saved me enough time, but at least I think I now understand the scale of things that I can/should send over to Copilot coding agent, and which ones I should not.
|
NOTE: The breaking changes from this (i.e. |
CvvT
left a comment
There was a problem hiding this comment.
This one looks like taking more manual efforts to make it right. Thanks Jay!
|
🤖 SemverChecks 🤖 Click for details |
This PR implements metadata support for network interfaces, similar to what was done for file systems in PR #76. This addresses the discussion point from PR #116 about adding metadata capabilities to network sockets.
This finishes part of the work towards #119.