Merged
Conversation
wdcui
reviewed
Feb 12, 2026
Member
wdcui
left a comment
There was a problem hiding this comment.
I went through the code and left some comments. Thank you for adding 9p support in LiteBox!
|
🤖 SemverChecks 🤖 Click for details |
wdcui
approved these changes
Feb 24, 2026
Member
wdcui
left a comment
There was a problem hiding this comment.
I left two comments unresolved. Once you create issues to track them, please feel free to merge this PR. Thanks!
Member
|
I resolved all my comments. Please feel free to merge it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds implementation of 9p fs that uses 9P2000.L protocol. For testing, I used
diodas the remote server. The implementation of 9p client was largely migrated from VSBox.Note that different from other fs, this only support blocking operations as it relies on network. Not sure if it breaks any assumption that LiteBox has.
Currently it only allows issuing one call over network at a time and waiting for it to complete. We should allow concurrent requests. I will fix it in the next PR.