Merged
Conversation
Member
Author
|
We plan to potentially remove iced-x86 from our dependencies, esp since we might want future ARM support, but at least this PR should fix some of the rare CI failures we see from time to time. |
jaybosamiya-ms
force-pushed
the
jayb/rare-rewriter-failure-fix
branch
from
df6c2f2 to
e0f78f1
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rare panic occurs inside iced-x86 (example) due to an integer underflow when the bytes that are being decoded are near a 4GiB boundary. There is already a fix available+merged upstream (icedland/iced#697) but a new version has not been released for iced-x86 onto crates.io in ~2 years (see icedland/iced#762 for issue requesting a new release semi-recently).
This PR fixes this by simply making sure we are not passing iced-x86 a 4GiB-boundary-crossing bytes.