Add support for setting up platform root key for LVBS#772
Add support for setting up platform root key for LVBS#772
Conversation
0d156f1 to
0fb51d4
Compare
|
@jaybosamiya-ms I've added |
|
@tgopinath-microsoft This PR introduces a VTL function/call for setting a platform root key ( |
|
Once this PR is merged, I'll rebase #643 . |
c96a162 to
8527327
Compare
| /// This function assumes that the caller stores the key data in a single or | ||
| /// contiguous physical memory page(s). If the caller cannot ensure this, | ||
| /// we should make this function use `HekiPage`. | ||
| fn mshv_vsm_set_platform_root_key(key_pa: u64, key_size: u64) -> Result<i64, VsmError> { |
There was a problem hiding this comment.
Do you think we will have the key size to be something other than 8 bytes ? If no, may be just need the key_pa and we do not need the size argument ? If you think we should extend the root key to be more than 8 bytes, then maybe we can have a an array of 8 bytes for key_pa and then specify the size in key_size
There was a problem hiding this comment.
I think the key should be at least 32 bytes (16 bytes might be okay but a bit weak)? If this something about we don't need to support various key size options, I think it is okay to only support a 32-byte root key.
There was a problem hiding this comment.
Ah I somehow mistook key_pa as key. ok then let us just support a 32 byte key and do away with the size
There was a problem hiding this comment.
sounds good. I'll revise the function signature.
|
🤖 SemverChecks 🤖 Click for details |
This PR adds support for setting up the Platform Root Key for the LVBS platform, which can be used to derive other keys like per-TA keys.