Fix breakage of kdata load#849
Merged
Merged
Conversation
femiatl
approved these changes
May 15, 2026
Contributor
femiatl
left a comment
femiatl
left a comment
There was a problem hiding this comment.
Looks good. Nit on title spelling "prem-maturely" -> prematurely
sangho2
reviewed
May 15, 2026
sangho2
reviewed
May 15, 2026
sangho2
reviewed
May 15, 2026
sangho2
approved these changes
May 15, 2026
kdata load return prem-maturely because KexecTrampoline metadata is only 2048 and hence not page aligned. For now let kdata load continue and ignore KexecTrampoline metadata if the size does not match. This is a basic fix to prevent heki itself from breaking. A final fix requires discussion on whether the metadata should be atleast a page and code changes possibly in VTL0 and VTL1.
tgopinath-microsoft
force-pushed
the
thara/fix-kdata
branch
from
9ba664b to
bed06f7
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kdata load return prematurely because KexecTrampoline metadata is only 2048 and hence not page aligned. For now let kdata load continue and ignore KexecTrampoline metadata if the size does not match. This is a basic fix to prevent heki itself from breaking. A final fix requires discussion on whether the metadata should be atleast a page and code changes possibly in VTL0 and VTL1.