Release/2.9 #172
Merged
Release/2.9 #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update issue templates Add in new issue templates for bug reports and feature requests. Bug reports will have a basic template covering "description", "error messages", and "chef exceptions" Feature requests will have a basic template covering "description", and a "reasoning behind feature" * fix spacing for bug report and feature request templates * add pull request template * update changelog with changes * respond to code review comments and change header to ## * respond to code review comments and use Justification and change header to ## * move CONTRIBUTING and PULL_REQUEST_TEMPLATE into ISSUE_TEMPLATE directory as suggested in PR comments * move github specific docs into github folder * move shared docs into root
- Paired with Andre Shields and Chris Gilbert
Co-Authored-By: v-anshie <v-anshie@microsoft.com>
added description of user/group plist support.
Paired with Chris Gilbert, Andre Shields, Carrol Fifer
Add support for owner/group to plist resource
mjmerin
suggested changes
Dec 21, 2018
Co-Authored-By: v-anshie <v-anshie@microsoft.com>
mjmerin
approved these changes
Dec 21, 2018
Contributor
|
It might be helpful to add unit or integration testing to validate the behavior of modifications to the user or group of an existing plist. |
chrismarlin
approved these changes
Dec 28, 2018
|
Could it be that there was something wrong releasing this to the Chef supermarket? Or does merging this not necessarely mean that the new version is being released? |
Contributor
|
Sorry about that @jeroenj. 2.9.0 is now available on the Chef Supermarket. https://supermarket.chef.io/cookbooks/macos/versions/2.9.0 |
|
Thanks! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plistresource. This allows control over setting the file permissions. (Issue #51)