Skip to content

fix: write UTF-8 bytes directly to stdout to avoid encoding errors #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuleinist wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

fix: write UTF-8 bytes directly to stdout to avoid encoding errors #1800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/markitdown/src/markitdown/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,14 @@ def _handle_output(args, result: DocumentConverterResult):
with open(args.output, "w", encoding="utf-8") as f:
f.write(result.markdown)
else:
# Handle stdout encoding errors more gracefully
print(
result.markdown.encode(sys.stdout.encoding, errors="replace").decode(
sys.stdout.encoding
)
)
# Write UTF-8 bytes directly to stdout's underlying buffer to avoid
# encoding errors on Windows (cp1252, gbk, etc.) and piped stdout
# where sys.stdout.encoding may be limited or None.
if hasattr(sys.stdout, "buffer"):
sys.stdout.buffer.write(result.markdown.encode("utf-8"))
else:
# Fallback for unusual stdout configurations
print(result.markdown, encoding="utf-8", errors="replace")


def _exit_with_error(message: str):
Expand Down