fix: IpynbConverter.accepts() returns False instead of raising on non-decodable content#1910
Closed
wali-reheman wants to merge 1 commit into
Closed
Conversation
…-decodable content Wraps decode in try/except to catch UnicodeDecodeError and ValueError when a file with application/json mimetype contains non-notebook content (e.g. a binary or non-ASCII file misidentified as JSON). This prevents the converter from crashing the entire conversion pipeline when it encounters files it should simply skip. Fixes microsoft#1894
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles UnicodeDecodeError and ValueError gracefully in accepts() when a file with application/json mimetype can't be decoded as text — instead of crashing the full conversion pipeline, it just returns False so the converter skips the file.
Fixes #1894.