fix: handle UnicodeDecodeError in CsvConverter when charset detection is inaccurate (fixes #1949)#1954
Open
hanhan761 wants to merge 1 commit into
Open
Conversation
… is inaccurate (fixes microsoft#1949)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CsvConverter.decode()usesstream_info.charset(detected from partial file content) to decode CSV files. When the detected charset is inaccurate (e.g.,'ascii'from the first 4096 bytes, but the full file contains UTF-8 characters), the decode fails withUnicodeDecodeError.This fix adds a fallback: if decoding with the detected charset fails, use
charset_normalizerfor automatic charset detection on the full file content.This is the same class of bug as #1505 (PlainTextConverter), which was fixed in PR #1938.
Issue
Fixes #1949
Verification