fix: fall back to charset_normalizer when detected charset fails to decode (fixes #1949)#1956
Open
hanhan761 wants to merge 1 commit into
Open
fix: fall back to charset_normalizer when detected charset fails to decode (fixes #1949)#1956hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
…ecode CSV/plain text (fixes microsoft#1949)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes UnicodeDecodeError in CsvConverter and PlainTextConverter when stream_info.charset reports a charset (e.g., 'ascii') that doesn't match the actual file content.
Root Cause
Both converters call .decode(stream_info.charset) on the full file content. When charset detection runs on a partial file prefix (first 4096 bytes) that happens to be ASCII-only but the full file contains non-ASCII bytes (e.g., UTF-8), the decode fails with UnicodeDecodeError.
Changes
Both files also now read
aw bytes once instead of calling ile_stream.read() twice.
Issue
Fixes #1949
Verification