Skip to content

V0.2 backend dynamic node support#172

Merged
Jinyu-W merged 223 commits into
microsoft:v0.2from
chaosddp:v0.2_backend_dynamic
Jan 22, 2021
Merged

V0.2 backend dynamic node support#172
Jinyu-W merged 223 commits into
microsoft:v0.2from
chaosddp:v0.2_backend_dynamic

Conversation

@chaosddp
Copy link
Copy Markdown
Contributor

@chaosddp chaosddp commented Oct 30, 2020

Description

Main changes:

  1. use an enum like class to specified attribute,

  2. support more attribute data type for both 2 backends.

  3. use a simple string template to generate dup codes before compiling.

  4. a backend write with c++ to support dynamic attributes

  5. add 2 attribute parameters,
    const: same as normal, but not copied into snapshot list, can be queried even without snapshot taking (must specified a tick for padding)
    list: dynamic length attribute, support remove, append, clear, resize and slice accessing.

    An attribute cannot both be const and list, it will cause an error.

# Linked issue(s)/Pull request(s)

#109
#110
#141

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

Comment thread docs/source/key_components/data_model.rst Outdated
Comment thread docs/source/key_components/data_model.rst Outdated
Comment thread docs/source/key_components/data_model.rst Outdated
Comment thread docs/source/key_components/data_model.rst
Comment thread maro/backends/_raw_get_attribute_type_.pyx.tml Outdated
Comment thread maro/backends/_raw_backend_attr_acc_.pyx.tml Outdated
Comment thread maro/backends/raw/node.cpp Outdated
Comment thread maro/backends/raw/frame.cpp Outdated
Comment thread maro/backends/raw/snapshotlist.cpp Outdated
@Jinyu-W Jinyu-W merged commit 97e4fa8 into microsoft:v0.2 Jan 22, 2021
@Jinyu-W Jinyu-W mentioned this pull request Jan 25, 2021
20 tasks
@chaosddp chaosddp removed the awaiting review Wait for the reviewer's comments. label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants