Skip to content

V0.1 reformat imports with isort#184

Merged
ArthurJiang merged 16 commits into
v0.1from
v0.1_reformat
Nov 5, 2020
Merged

V0.1 reformat imports with isort#184
ArthurJiang merged 16 commits into
v0.1from
v0.1_reformat

Conversation

@Jinyu-W
Copy link
Copy Markdown
Contributor

@Jinyu-W Jinyu-W commented Nov 5, 2020

Description

  • add isort in the CONTRIBUTING.md
  • reformat all files in maro with isort command, configured with tox.ini
  • reformat related files in maro according to lint alert

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@Jinyu-W Jinyu-W changed the base branch from master to v0.1 November 5, 2020 03:32
@Jinyu-W Jinyu-W requested a review from ArthurJiang November 5, 2020 03:32
@Jinyu-W Jinyu-W added the in progress Not finished items/bugs. label Nov 5, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 5, 2020

Codecov Report

Merging #184 into v0.1 will decrease coverage by 0.42%.
The diff coverage is 82.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.1     #184      +/-   ##
==========================================
- Coverage   72.49%   72.06%   -0.43%     
==========================================
  Files          86       86              
  Lines        4064     4066       +2     
==========================================
- Hits         2946     2930      -16     
- Misses       1118     1136      +18     
Flag Coverage Δ
unittests 72.06% <82.82%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
maro/communication/utils/default_parameters.py 100.00% <ø> (ø)
maro/rl/shaping/action_shaper.py 71.42% <ø> (ø)
maro/rl/shaping/experience_shaper.py 66.66% <ø> (ø)
maro/rl/shaping/state_shaper.py 71.42% <ø> (ø)
...simulator/scenarios/citi_bike/decision_strategy.py 42.76% <0.00%> (ø)
...aro/simulator/scenarios/citi_bike/weather_table.py 100.00% <ø> (ø)
maro/simulator/scenarios/helpers.py 74.32% <ø> (ø)
maro/communication/registry_table.py 94.26% <50.00%> (ø)
maro/event_buffer/event_buffer.py 96.29% <66.66%> (ø)
maro/utils/utils.py 48.80% <66.66%> (-21.43%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077c367...4bc5f24. Read the comment docs.

@Jinyu-W Jinyu-W added awaiting review Wait for the reviewer's comments. and removed in progress Not finished items/bugs. labels Nov 5, 2020
@ArthurJiang ArthurJiang merged commit f6e1870 into v0.1 Nov 5, 2020
@ArthurJiang ArthurJiang deleted the v0.1_reformat branch November 5, 2020 09:33
Jinyu-W added a commit that referenced this pull request Nov 5, 2020
* refine readme

* feat: refine data push/pull (#138)

* feat: refine data push/pull

* test: add cli provision testing

* fix: style fix

* fix: add necessary comments

* fix: from code review

* add fall back function in weather download (#112)

* fix deployment issue in multi envs

* fix typo

* fix ~/.maro not exist issue in build

* skip deploy when build

* update for comments

* temporarily disable weather info

* replace ecr with cim in setup.py

* replace ecr in manifest

* remove weather check when read data

* fix station id issue

* fix format

* add TODO in comments

* add noaa weather source

* fix weather reset and weather comment

* add comment for weather data url

* some format update

* add fall back function in weather download

* update comment

* update for comments

* update comment

* add period

* fix for pylint

* update for pylint check

* added example docs (#136)

* added example docs

* added citibike greedy example doc

* modified citibike doc

* fixed PR comments

* fixed more PR comments

* fixed small formatting issue

Co-authored-by: ysqyang <v-yangqi@microsoft.com>

* switch the key and value of handler_dict in decorator (#144)

* switch the key and value of handler_dict in decorator

* add dist decorator UT and fixed multithreading conflict in maro test suite

* pr comments update.

* resolved comments about decorator UT

* rename handler_fun in dist decorator

* change self.attr into class_name.attr

* update UT tests comments

* V0.1 annotation (#147)

* refine the annotation of simulator core

* remove reward from env(be)

* format refined

* white spaces test

* left-padding spaces refined

* format modifed

* update the left-padding spaces of docstrings

* code format updated

* update according to comments

* update according to PR comments

Co-authored-by: Jinyu Wang <Wang.Jinyu@microsoft.com>

* V0.1 issues in CLI (#157)

* fix: add docs for AzCopy

* style: refine code style

* fix: change stdout format to previous version

* test: add dqn tests in grass/k8s mode && add "maro k8s job list"

* docs: add scripts for installing AzCopy

* v0.1 update citi bike doc and data version (#160)

* fix deployment issue in multi envs

* fix typo

* fix ~/.maro not exist issue in build

* skip deploy when build

* update for comments

* temporarily disable weather info

* replace ecr with cim in setup.py

* replace ecr in manifest

* remove weather check when read data

* fix station id issue

* fix format

* add TODO in comments

* add noaa weather source

* fix weather reset and weather comment

* add comment for weather data url

* some format update

* add fall back function in weather download

* update comment

* update for comments

* update comment

* add period

* fix for pylint

* update for pylint check

* update data pipeline docs and data version

* update for comments

* update for comments

* update for lint

* update for lint

* update for lint

* V0.1revert data version to 0.1 (#164)

* fix deployment issue in multi envs

* fix typo

* fix ~/.maro not exist issue in build

* skip deploy when build

* update for comments

* temporarily disable weather info

* replace ecr with cim in setup.py

* replace ecr in manifest

* remove weather check when read data

* fix station id issue

* fix format

* add TODO in comments

* add noaa weather source

* fix weather reset and weather comment

* add comment for weather data url

* some format update

* add fall back function in weather download

* update comment

* update for comments

* update comment

* add period

* fix for pylint

* update for pylint check

* update data pipeline docs and data version

* update for comments

* update for comments

* update for lint

* update for lint

* update for lint

* revert data version to 0.1

* initalize gnn network for CIM problem (#60)

* initalize gnn netowrk for ECR problem

* fix import path error and remove useless function

* add the annotation for gnn and state shaper

* rename to cim

* modify topology 22p

* polish coding style in cim.gnn

* run pass after polishing

* change the name of simplegat to simple_transformer

* fix typo and suggestions

* fix format

* fix code bugs due to refactoring mistake

* refine the code format

* refine again

* refine the format

* refine again

* refine again

* fix syntax bug

* refine again

* remove useless comments

* remove unnecessary blank line

* rename pending_event to decision_event

* remove some code faced to the future.

* change topology

* fix bugs in learner: no training logic executed

* revert the topology changes

Co-authored-by: wenshi-113 <wenshi@microsoft.com>

* V0.1 store unpicklable bug fix (#166)

* fixed unpicklable store bug

* fixed a bug

* fixed a bug

* fixed a bug

* fixed lint formatting

* fixed a lint formatting issue

* fixed a bug

* renamed dump_experience_store to dump_experience_pool

* fixed a PR comment

Co-authored-by: ysqyang <v-yangqi@microsoft.com>

* V0.1 confusing component naming fix (#167)

* confusing component naming fix

* fixed a bug

* fixed a bug

* fixed lint formatting issues

* fixed a PR comment

* replaced 'actor_worker' with 'actor'

* fixed a minor formatting issue

* fixed a minor formatting issue

* fixed a minor formatting issue

Co-authored-by: ysqyang <v-yangqi@microsoft.com>

* version updated to 0.1.2a0

* modified according to flake8

* update according to lint checker

* update import format according to lint checker

* update according to lint checker

* isort config added

* add isort config file path in lint

* update import according to lint isort

* update import according to lint isort

* skip file added for isort linter

* filter files option added for isort

* V0.1 reformat imports with isort (#184)

* init auto-isort

* re-format maro init

* redis added to isort known third party

* update according to lint isort

* update according to lint isort

* update according to lint

* update import path for communication module

* update import path for cli scripts module

* update according to lint

* filter file option added for isort in CONTRIBUTING

* update import path for cli utils and communication

* update import path for tests

* remove filter file option in CONTRIBUTING

Co-authored-by: Jinyu Wang <Wang.Jinyu@microsoft.com>

* update according to isort

Co-authored-by: Arthur Jiang <sjian@microsoft.com>
Co-authored-by: Romic Huang <romic.kid@gmail.com>
Co-authored-by: zhanyu wang <pocket_2001@163.com>
Co-authored-by: ysqyang <ysqyang@gmail.com>
Co-authored-by: ysqyang <v-yangqi@microsoft.com>
Co-authored-by: kaiqli <59279714+kaiqli@users.noreply.github.com>
Co-authored-by: Jinyu-W <53509467+Jinyu-W@users.noreply.github.com>
Co-authored-by: Jinyu Wang <Wang.Jinyu@microsoft.com>
Co-authored-by: Jinyu Wang <jinywan@microsoft.com>
Co-authored-by: WesleyStone <4548088+wesley-stone@users.noreply.github.com>
Co-authored-by: wenshi-113 <wenshi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Wait for the reviewer's comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants