Skip to content

V0.2 vm region support#258

Merged
Jinyu-W merged 54 commits into
v0.2from
v0.2_vm_region
Feb 9, 2021
Merged

V0.2 vm region support#258
Jinyu-W merged 54 commits into
v0.2from
v0.2_vm_region

Conversation

@kyu-kuanwei
Copy link
Copy Markdown
Contributor

@kyu-kuanwei kyu-kuanwei commented Jan 21, 2021

Description

  1. Add region, zone, cluster layers (PM).
  2. Build the snapshots of region, zone, cluster.
  3. Add a basic config of region, zone, cluster structure.
  4. Add unit test.
  5. Add simulation results.
  6. Add multiple config settings.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@kyu-kuanwei kyu-kuanwei added awaiting review Wait for the reviewer's comments. v0.2 vm scheduling data center scenario. labels Jan 21, 2021
@kyu-kuanwei kyu-kuanwei requested a review from Jinyu-W January 21, 2021 06:06
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 21, 2021

Codecov Report

Merging #258 (dc95da4) into v0.2 (f2c82fb) will increase coverage by 2.85%.
The diff coverage is 85.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.2     #258      +/-   ##
==========================================
+ Coverage   64.02%   66.87%   +2.85%     
==========================================
  Files         110      115       +5     
  Lines        5634     5992     +358     
==========================================
+ Hits         3607     4007     +400     
+ Misses       2027     1985      -42     
Flag Coverage Δ
unittests 66.87% <85.86%> (+2.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mulator/scenarios/vm_scheduling/business_engine.py 49.31% <77.84%> (+31.36%) ⬆️
maro/simulator/scenarios/vm_scheduling/region.py 87.50% <87.50%> (ø)
maro/simulator/scenarios/vm_scheduling/zone.py 88.88% <88.88%> (ø)
...o/simulator/scenarios/vm_scheduling/data_center.py 90.00% <90.00%> (ø)
maro/simulator/scenarios/vm_scheduling/cluster.py 90.90% <90.90%> (ø)
maro/simulator/scenarios/vm_scheduling/rack.py 91.66% <91.66%> (ø)
...simulator/scenarios/vm_scheduling/frame_builder.py 100.00% <100.00%> (+62.50%) ⬆️
...ulator/scenarios/vm_scheduling/physical_machine.py 86.66% <100.00%> (+44.84%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c82fb...dc95da4. Read the comment docs.

Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/cluster.py
Comment thread maro/simulator/scenarios/vm_scheduling/frame_builder.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/cluster.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/cluster.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/rack.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/rack.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/rack.py
Comment thread maro/simulator/scenarios/vm_scheduling/region.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/region.py
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/cluster.py
Comment thread maro/simulator/scenarios/vm_scheduling/cluster.py
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py
Comment thread maro/simulator/scenarios/vm_scheduling/cluster.py
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.10k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/topologies/azure.2019.336k/config.yml Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/zone.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Comment thread maro/simulator/scenarios/vm_scheduling/business_engine.py Outdated
Jinyu-W
Jinyu-W previously approved these changes Feb 9, 2021
Jinyu-W
Jinyu-W previously approved these changes Feb 9, 2021
@Jinyu-W Jinyu-W merged commit e31bea3 into v0.2 Feb 9, 2021
@Jinyu-W Jinyu-W deleted the v0.2_vm_region branch February 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Wait for the reviewer's comments. v0.2 vm scheduling data center scenario.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants