Skip to content

V0.2 merge algorithm into agent#259

Merged
wesley-stone merged 48 commits into
v0.2from
v0.2_merge_algorithm_into_agent
Feb 1, 2021
Merged

V0.2 merge algorithm into agent#259
wesley-stone merged 48 commits into
v0.2from
v0.2_merge_algorithm_into_agent

Conversation

@ysqyang
Copy link
Copy Markdown
Contributor

@ysqyang ysqyang commented Jan 22, 2021

Description

RL toolkit refinement: 1. merged Algorithm into Agent; 2. removed state shaper, action shaper and experience shaper abstractions as they don't provide additional benefits beyond the Shaper class; 3. refined action sampling logic using torch's Categorical class for policy optimization algorithmsl; 4. removed input_dim and output_dim property requirements from LearningModel.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 23, 2021

Codecov Report

Merging #259 (201eb61) into v0.2 (0a6f9f0) will increase coverage by 0.10%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.2     #259      +/-   ##
==========================================
+ Coverage   64.01%   64.11%   +0.10%     
==========================================
  Files         114      108       -6     
  Lines        5605     5471     -134     
==========================================
- Hits         3588     3508      -80     
+ Misses       2017     1963      -54     
Flag Coverage Δ
unittests 64.11% <40.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
maro/rl/model/abs_block.py 66.66% <ø> (ø)
maro/rl/model/fc_block.py 22.91% <ø> (ø)
maro/utils/exception/error_code.py 100.00% <ø> (ø)
maro/utils/exception/rl_toolkit_exception.py 68.42% <ø> (+0.42%) ⬆️
maro/rl/learner/simple_learner.py 43.24% <16.66%> (ø)
maro/rl/actor/simple_actor.py 28.57% <28.57%> (ø)
maro/rl/agent/abs_agent.py 51.72% <28.57%> (-1.61%) ⬇️
maro/rl/model/learning_model.py 32.18% <28.57%> (ø)
maro/rl/agent/dqn.py 23.46% <32.50%> (ø)
maro/rl/agent_manager/abs_agent_manager.py 34.04% <34.04%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6f9f0...201eb61. Read the comment docs.

wesley-stone
wesley-stone previously approved these changes Jan 29, 2021
@ysqyang ysqyang requested a review from wesley-stone January 29, 2021 12:42
wesley-stone
wesley-stone previously approved these changes Feb 1, 2021
@wesley-stone wesley-stone merged commit a46f1f9 into v0.2 Feb 1, 2021
@ysqyang ysqyang deleted the v0.2_merge_algorithm_into_agent branch February 1, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants