Add vector env support#266
Merged
Merged
Conversation
… control the tick for each environments
chaosddp
added
in progress
chaosddp
added
awaiting review
Codecov Report
@@ Coverage Diff @@
## v0.2 #266 +/- ##
==========================================
+ Coverage 64.01% 64.15% +0.13%
==========================================
Files 114 116 +2
Lines 5605 5755 +150
==========================================
+ Hits 3588 3692 +104
- Misses 2017 2063 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jinyu-W
suggested changes
Feb 1, 2021
…to v0.2.vector_env
…to v0.2.vector_env
Jinyu-W
reviewed
Feb 1, 2021
Jinyu-W
reviewed
Feb 1, 2021
| # Update cost. | ||
| num = abs(move_num) | ||
| if action_type == ActionType.DISCHARGE: | ||
| assert(move_num <= vessel_empty) |
Contributor
There was a problem hiding this comment.
also need to check the port capacity?
I remember we have this attribute but just with a big enough value?
Contributor
Author
There was a problem hiding this comment.
Arthur and Ruidong removed this checking long long ago, I am not sure why, so sometime we can see that the empty+full may greater than capacity in cim vis page.
Jinyu-W
approved these changes
Feb 1, 2021
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a simple multiple-process based vector environments class (via command with Pipe), to support start multiple environments to train.
Linked issue(s)/Pull request(s)
Type of Change
Related Component
Has Been Tested
Needs Follow Up Actions
Checklist