Skip to content

fixed internal logger dumplicated output#299

Merged
Jinyu-W merged 4 commits into
microsoft:v0.2from
kaiqli:v0.2_logger_fixed
Mar 22, 2021
Merged

fixed internal logger dumplicated output#299
Jinyu-W merged 4 commits into
microsoft:v0.2from
kaiqli:v0.2_logger_fixed

Conversation

@kaiqli
Copy link
Copy Markdown
Contributor

@kaiqli kaiqli commented Mar 22, 2021

Description

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.6
    • 3.7
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2021

Codecov Report

Merging #299 (3e5da8e) into v0.2 (2887bb0) will decrease coverage by 0.45%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.2     #299      +/-   ##
==========================================
- Coverage   68.75%   68.29%   -0.46%     
==========================================
  Files         115      115              
  Lines        6128     6123       -5     
==========================================
- Hits         4213     4182      -31     
- Misses       1915     1941      +26     
Flag Coverage Δ
unittests 68.29% <0.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
maro/communication/message.py 67.39% <0.00%> (-1.24%) ⬇️
maro/utils/logger.py 44.27% <0.00%> (-20.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2887bb0...3e5da8e. Read the comment docs.

@Jinyu-W Jinyu-W self-requested a review March 22, 2021 05:01
@Jinyu-W Jinyu-W merged commit ed0ff75 into microsoft:v0.2 Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants