CI: trim build workflow matrix and collapse build+test#148
Merged
yanghan234 merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
…ize actions Agent-Logs-Url: https://github.com/microsoft/mattersim/sessions/1419ade8-5746-4e23-a862-a793f814ad4f Co-authored-by: yanghan234 <32856137+yanghan234@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
yanghan234
April 21, 2026 14:58
View session
The create-args approach conflicts with the python=3.10 pin in environment.yaml, causing conda solver failures on Python 3.12. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
yanghan234
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build and Test with Mambaworkflow ran a fullos × python-versionmatrix (2 OSes × 4 Python versions) across two sequential jobs, producing 16 runs per push/PR with little added signal — the project has no version-specific code paths beyond the>=3.10floor, and thebuildjob was redundant withtest.Changes to
.github/workflows/build.yamltestjob. Dropped the separatebuildjob;uv pip install ".[dev]"intestalready exercises the install path. Also removed theactions/cacheblock that pointed at the wrong env path and never hit —setup-micromamba'scache-environment: truehandles this.ubuntu-latest × {3.10, 3.12}(pinned floor + one current Python) plus a singlemacos-latest × 3.10smoke test viainclude:. 16 runs → 3.sedrewrite ofenvironment.yamlwithcreate-args: python=${{ matrix.python-version }}.actions/checkoutto v4, addedconcurrencyto cancel superseded PR runs, setfail-fast: false, and added a minimalpermissions: contents: readblock.Test invocation is unchanged (
pytest -v tests --disable-warnings);environment.yaml'spython=3.10pin is left as-is to document the supported floor.Open questions for reviewers: whether to keep the macOS smoke test on every PR or move it to a scheduled/release-only run, and whether
3.13should be added back once pinned scientific deps officially support it.