Add ToolId to telemetry and support local telemetry#1018
Merged
alzimmermsft merged 6 commits intomicrosoft:mainfrom Nov 3, 2025
Merged
Add ToolId to telemetry and support local telemetry#1018alzimmermsft merged 6 commits intomicrosoft:mainfrom
alzimmermsft merged 6 commits intomicrosoft:mainfrom
Conversation
conniey
reviewed
Oct 30, 2025
alzimmermsft
requested review from
JonathanCrd,
Copilot,
fanyang-mono,
hallipr,
jairmyree,
joshfree,
vukelich and
wbreza
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry support for tracking tool IDs and enables optional OTLP (OpenTelemetry Protocol) export functionality.
Key changes:
- Added
ToolIdtag to track unique tool identifiers in telemetry - Implemented conditional OTLP exporter based on environment variable
- Set
ToolIdtag in all tool execution paths (CommandFactory, NamespaceToolLoader, CommandFactoryToolLoader)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TelemetryConstants.cs | Added new ToolId constant for telemetry tag naming |
| OpenTelemetryExtensions.cs | Added OTLP exporter configuration with environment variable flag and stored builder reference |
| CommandFactory.cs | Set ToolId tag on activity when executing commands |
| NamespaceToolLoader.cs | Set ToolId tag on activity for namespace tool execution and removed unused import |
| CommandFactoryToolLoader.cs | Set ToolId tag on activity for command factory tool execution and removed unused import |
conniey
reviewed
Oct 31, 2025
conniey
reviewed
Oct 31, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Add ToolId to telemetry and support local telemetry * Change how ToolId is set * using cleanup * Fix copy-paste error * CHANGELOG and troubleshooting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes how tools are executed to support adding
ToolIdinto every telemetry call for a specific tool.Adds support for
AZURE_MCP_ENABLE_OTLP_EXPORTERenvironment variable to enable OTLP in addition to Azure Monitor telemetry exporting.GitHub issue number?
Fixes https://github.com/microsoft/mcp-pr/issues/136
Fixes #1004
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline