Update VSIX to register version.#1050
Merged
g2vinay merged 4 commits intomicrosoft:mainfrom Nov 22, 2025
Merged
Conversation
g2vinay
requested review from
hallipr,
joshfree,
msalaman,
tmeschter and
weshaggard
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds version tracking to the Azure MCP Server by passing the package version from package.json to the McpStdioServerDefinition constructor. This enables better versioning and tracking of the MCP server instance.
- Added
packageJsonconstant at module level to read version from package.json - Updated
McpStdioServerDefinitionconstructor call to include the version parameter
Comments suppressed due to low confidence (1)
servers/Azure.Mcp.Server/vscode/src/extension.ts:1
- The test mock for
MockMcpStdioServerDefinitiondoesn't include the newversionparameter in its constructor signature. This mock should be updated to accept a version parameter (even if unused) to match the actual API being called, ensuring tests accurately reflect the production code.
// Copyright (c) Microsoft Corporation. All rights reserved.
Member
|
Let's backport this to 1.x too |
joshfree
previously requested changes
Nov 4, 2025
Member
joshfree
left a comment
joshfree
left a comment
There was a problem hiding this comment.
Please update changelog - make it REALLY clear that this is an important fix
JasonYeMSFT
approved these changes
Nov 4, 2025
Member
|
You may ping owners of other MCP servers to check this as well. Or you can check it for them. |
hallipr
approved these changes
Nov 4, 2025
Member
|
Should we have a common module for use by the servers' extension.ts files? I feel like there's going to be a large amount of code that's just copy-pasted between servers. |
g2vinay
force-pushed
the
update-vsix-versioning
branch
from
3ed5795 to
eeac572
Compare
KarishmaGhiya
approved these changes
Nov 22, 2025
vcolin7
approved these changes
Nov 22, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates VSIX to register version, to prompt refresh of tools in VS code iDE.