Merged
Conversation
vukelich
requested review from
a team,
HaofanLiao,
JialinXin,
achyuth-ms,
alzimmermsft,
anuchandy,
conniey,
ericshape,
ivarprudnikov,
jongio,
kk-src,
mattkohnms,
mitesh-pv,
nishtha489,
pablocastro,
philon-msft,
qianwens,
ramnov,
sharedferret,
srnagar,
taicchoumsft,
vladimisms,
vurhanau,
wolfgang-desalvador and
xiangyan99
as code owners
joshfree
approved these changes
Nov 4, 2025
kvenkatrajan
approved these changes
Nov 4, 2025
joshfree
approved these changes
Nov 5, 2025
Add a CancellationToken parameter to IBaseCommand.ExecuteAsync. - Plumb CancellationToken through most of the product code with CancellationToken.None used temporarily where needed. - Update unit tests to use Arg.Any<CancellationToken>() when mocking methods that now take a CancellationToken parameter. - Add documentation guidance for unit tests regarding CancellationToken usage. More product code and unit tests will be updated in subsequent commits.
vukelich
force-pushed
the
users/vukelich/cancellation
branch
from
88f5458 to
dbd5d32
Compare
joshfree
approved these changes
Nov 5, 2025
srnagar
approved these changes
Nov 5, 2025
srnagar
approved these changes
Nov 5, 2025
Member
srnagar
left a comment
srnagar
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for updating the contributing guides and new-command.md.
conniey
approved these changes
Nov 5, 2025
Member
conniey
left a comment
conniey
left a comment
There was a problem hiding this comment.
Nice! From what I saw in the files, a CancellationToken parameter was added to each method. That'll be useful. : )
Member
|
CI failed on 
|
joshfree
approved these changes
Nov 5, 2025
This was referenced Nov 11, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* The Great Cancellation: Part 1 Add a CancellationToken parameter to IBaseCommand.ExecuteAsync. - Plumb CancellationToken through most of the product code with CancellationToken.None used temporarily where needed. - Update unit tests to use Arg.Any<CancellationToken>() when mocking methods that now take a CancellationToken parameter. - Add documentation guidance for unit tests regarding CancellationToken usage. More product code and unit tests will be updated in subsequent commits. * Typo and adding newline to test files with style errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Add a CancellationToken parameter to IBaseCommand.ExecuteAsync.
More product code and unit tests will be updated in subsequent commits.
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline